[
https://issues.apache.org/jira/browse/FLINK-2837?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15027174#comment-15027174
]
ASF GitHub Bot commented on FLINK-2837:
---------------------------------------
Github user mjsax commented on a diff in the pull request:
https://github.com/apache/flink/pull/1398#discussion_r45893736
--- Diff:
flink-contrib/flink-storm/src/test/java/org/apache/flink/storm/api/FlinkTopologyTest.java
---
@@ -14,50 +14,70 @@
* See the License for the specific language governing permissions and
* limitations under the License.
*/
-
package org.apache.flink.storm.api;
-import org.apache.flink.storm.api.FlinkTopology;
-import org.junit.Assert;
+
+import backtype.storm.topology.TopologyBuilder;
+import backtype.storm.tuple.Fields;
+import org.apache.flink.storm.util.TestDummyBolt;
+import org.apache.flink.storm.util.TestDummySpout;
+import org.apache.flink.storm.util.TestSink;
+import org.junit.Ignore;
import org.junit.Test;
public class FlinkTopologyTest {
- @Test
- public void testDefaultParallelism() {
- final FlinkTopology topology = new FlinkTopology();
- Assert.assertEquals(1, topology.getParallelism());
+ @Test(expected = RuntimeException.class)
+ public void testUnknowSpout() {
+ TopologyBuilder builder = new TopologyBuilder();
+ builder.setSpout("spout", new TestSpout());
+ builder.setBolt("bolt", new
TestBolt()).shuffleGrouping("unknown");
+
+ FlinkTopology.createTopology(builder);
}
- @Test(expected = UnsupportedOperationException.class)
- public void testExecute() throws Exception {
- new FlinkTopology().execute();
+ @Test(expected = RuntimeException.class)
+ public void testUnknowBolt() {
+ TopologyBuilder builder = new TopologyBuilder();
+ builder.setSpout("spout", new TestSpout());
+ builder.setBolt("bolt1", new
TestBolt()).shuffleGrouping("spout");
+ builder.setBolt("bolt2", new
TestBolt()).shuffleGrouping("unknown");
+
+ FlinkTopology.createTopology(builder);
}
- @Test(expected = UnsupportedOperationException.class)
- public void testExecuteWithName() throws Exception {
- new FlinkTopology().execute(null);
+ @Test(expected = RuntimeException.class)
+ public void testUndeclaredStream() {
+ TopologyBuilder builder = new TopologyBuilder();
+ builder.setSpout("spout", new TestSpout());
+ builder.setBolt("bolt", new
TestBolt()).shuffleGrouping("spout");
+
+ FlinkTopology.createTopology(builder);
}
@Test
- public void testNumberOfTasks() {
- final FlinkTopology topology = new FlinkTopology();
+ @Ignore
--- End diff --
Please enable this test. I forgot to do this in my last commit which fixes
this issue...
> FlinkTopologyBuilder cannot handle multiple input streams
> ---------------------------------------------------------
>
> Key: FLINK-2837
> URL: https://issues.apache.org/jira/browse/FLINK-2837
> Project: Flink
> Issue Type: Bug
> Components: Storm Compatibility
> Reporter: Matthias J. Sax
> Assignee: Maximilian Michels
>
> FlinkTopologyBuilder cannot handle multiple input streams correctly. Instead
> of union the incoming streams, it replicates the consuming bolt and each
> (logical) instance processes one of the input streams.
> For example:
> {noformat}
> final FlinkTopologyBuilder builder = new FlinkTopologyBuilder();
> builder.setSpout(spoutId1, new FiniteRandomSpout(0, 10));
> builder.setSpout(spoutId2, new FiniteRandomSpout(1, 8));
> builder.setSpout(spoutId3, new FiniteRandomSpout(2, 13));
> builder.setBolt(boltId, new MergerBolt())
> .shuffleGrouping(spoutId1)
> .shuffleGrouping(spoutId2)
> .shuffleGrouping(spoutId3);
> builder.setBolt("sink", new BoltPrintSink(new SimpleOutputFormatter()))
> .shuffleGrouping(boltId);
> {noformat}
> will only print the data from a single source instead of all sources.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
