Github user mjsax commented on a diff in the pull request:
https://github.com/apache/flink/pull/1398#discussion_r45894573
--- Diff:
flink-contrib/flink-storm/src/test/java/org/apache/flink/storm/wrappers/StormTupleTest.java
---
@@ -613,29 +611,29 @@ public void testGetBinaryByFieldPojoGetter() throws
Exception {
return new StormTuple(tuple, schema);
}
- @Test(expected = UnsupportedOperationException.class)
+ @Test
public void testGetSourceGlobalStreamid() {
- new StormTuple<Object>(null, null).getSourceGlobalStreamid();
+ Assert.assertNotNull(new StormTuple<Object>(null,
null).getSourceGlobalStreamid());
--- End diff --
Can we improve on all this tests? Just a check for "not-null" seems a
little limited to me. We should rather check for defaults values and also check
the full constructor case.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
