StephanEwen commented on issue #11196: [FLINK-16246][connector kinesis] Exclude 
AWS SDK MBean registry from Kinesis build
URL: https://github.com/apache/flink/pull/11196#issuecomment-590125983
 
 
   I thought about that a bit.
   
   Given that this code is shared between multiple sources / tasks in the same 
classloader, unregisterin in "close()" means when the first task is canceled or 
finished, the bean goes away. I am wondering if then it would not be better to 
never register it. Unless we do some tracking and remove the bean when the last 
strong reference to a AWS connector is released (some Phantom Reference magic?).
   
   That's why I first proposed this, it seemed simpler.
   If someone would be eager to invest time into a more elaborate solution, 
like an AWS metrics cleaner util, I'd be +1 for that.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to