zhijiangW commented on issue #11155: [FLINK-14818][benchmark] Fix receiving InputGate setup of StreamNetworkBenchmarkEnvironment. URL: https://github.com/apache/flink/pull/11155#issuecomment-590170854 Thanks for the updates @wsry and it generally looks good to me now, just left two tiny comments. As for the previous main concern, I left some suggestions [here](https://github.com/apache/flink/pull/11155#discussion_r383088089). After you providing the micro-benchmark results, I would also execute it in our benchmark machine to convince us.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
