tzulitai commented on issue #28: [FLINK-16159] [tests, build] Add verification integration test + integrate with Maven build URL: https://github.com/apache/flink-statefun/pull/28#issuecomment-590221029 @igalshilman all your comments have been addressed, and the PR is ready for review. Since the follow-up commit history got a bit out of control, I figured that it'll be easier if I rebased everything and squashed to understandable commits, and therefore had to force push. Besides some of the more minor comments: - I've introduced our own `StatefulFunctionsAppContainers` test rule that is based on Testcontainers. This would remove a lot of the cumbersome setup code from the actual test code, and makes it easier to setup multiple workers in the end-to-end tests. See 86ccc87. I can see this as a common utility to be used by other end-to-end tests in the future. - The test now runs in parallelism 2. This is done by adding a `flink-conf.yaml` with `parallelism.default=2` to the built application image, and having 2 workers in the `StatefulFunctionsAppContainers` test rule. - Concerning a more readable assertion of Kafka inputs and outputs (your comment [here](https://github.com/apache/flink-statefun/pull/28#discussion_r381997568)), I gave that a try and came up with a `KafkaIOVerifier` utility. See bb2e0cc. It's not 100% good though; needs a good way to verify end-of-output situations (please see the `TODO` in `KafkaIOVerifier`).
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
