azagrebin commented on a change in pull request #11110: [FLINK-16111][k8s] Fix
Kubernetes deployment not respecting 'taskmanager.cpu.cores'.
URL: https://github.com/apache/flink/pull/11110#discussion_r383148341
##########
File path:
flink-yarn/src/test/java/org/apache/flink/yarn/YarnResourceManagerTest.java
##########
@@ -526,6 +527,45 @@ public void testOnStartContainerError() throws Exception {
}};
}
+ @Test
+ public void testGetCpuCoresCommonOption() throws Exception {
+ final Configuration configuration = new Configuration();
+ configuration.setDouble(TaskManagerOptions.CPU_CORES, 1.0);
Review comment:
It would be nice also to test rounding up to 1.0 and next greater integer
for double values of `TaskManagerOptions.CPU_CORES`. Also, overrunning of
`Integer.MAX_VALUE`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
