AHeise commented on a change in pull request #11098: [FLINK-16060][task] 
Implement working StreamMultipleInputProcessor
URL: https://github.com/apache/flink/pull/11098#discussion_r383179373
 
 

 ##########
 File path: 
flink-streaming-java/src/main/java/org/apache/flink/streaming/api/graph/StreamConfig.java
 ##########
 @@ -174,19 +173,35 @@ public void setTypeSerializerSideOut(OutputTag<?> 
outputTag, TypeSerializer<?> s
                setTypeSerializer(TYPE_SERIALIZER_SIDEOUT_PREFIX + 
outputTag.getId(), serializer);
        }
 
+       @Deprecated
        public <T> TypeSerializer<T> getTypeSerializerIn1(ClassLoader cl) {
-               try {
-                       return 
InstantiationUtil.readObjectFromConfig(this.config, TYPE_SERIALIZER_IN_1, cl);
-               } catch (Exception e) {
-                       throw new StreamTaskException("Could not instantiate 
serializer.", e);
-               }
+               return getTypeSerializerIn(0, cl);
        }
 
+       @Deprecated
        public <T> TypeSerializer<T> getTypeSerializerIn2(ClassLoader cl) {
+               return getTypeSerializerIn(1, cl);
+       }
+
+       public TypeSerializer<?>[] getTypeSerializersIn(ClassLoader cl) {
+               int typeSerializersCount = 
config.getInteger(TYPE_SERIALIZERS_IN_COUNT, -1);
+               TypeSerializer<?>[] typeSerializers = new 
TypeSerializer<?>[typeSerializersCount];
 
 Review comment:
   handle -1? Would give a weird exception.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to