JingsongLi opened a new pull request #11204: [FLINK-16264][table] Fix 
ConnectTableDescriptor loose time attribute bug
URL: https://github.com/apache/flink/pull/11204
 
 
   
   ## What is the purpose of the change
   
   In `CatalogTableImpl.fromProperties`, we can not remove all `schema.*` for 
TableSchema, because Schema (it is a descriptor) is not same to TableSchema.  
Schema contains time attribute, so we need keep them in properties.
   
   ## Brief change log
   
   Remove per key for TableSchema in `CatalogTableImpl.fromProperties`.
   Add test `ConnectTableDescriptorTest`.
   
   ## Verifying this change
   
   `ConnectTableDescriptorTest`.
   
   ## Does this pull request potentially affect one of the following parts:
   
     - Dependencies (does it add or upgrade a dependency): (yes / **no**)
     - The public API, i.e., is any changed class annotated with 
`@Public(Evolving)`: (yes / **no**)
     - The serializers: (yes / **no** / don't know)
     - The runtime per-record code paths (performance sensitive): (yes / **no** 
/ don't know)
     - Anything that affects deployment or recovery: JobManager (and its 
components), Checkpointing, Kubernetes/Yarn/Mesos, ZooKeeper: (yes / **no** / 
don't know)
     - The S3 file system connector: (yes / **no** / don't know)
   
   ## Documentation
   
     - Does this pull request introduce a new feature? (yes / **no**)

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to