hequn8128 commented on a change in pull request #11198:
[FLINK-16248][python][ml] Add interfaces for MLEnvironment and
MLEnvironmentFactory
URL: https://github.com/apache/flink/pull/11198#discussion_r383707337
##########
File path: flink-python/pyflink/table/table_environment.py
##########
@@ -76,14 +76,24 @@ class TableEnvironment(object):
__metaclass__ = ABCMeta
- def __init__(self, j_tenv, is_blink_planner,
serializer=PickleSerializer()):
+ def __init__(self, j_tenv, serializer=PickleSerializer()):
Review comment:
Yes, it will be more friendly to create the corresponding table environment
in `MLEnvironmentFactory.get_default()`, e.g., we don not need to pass the
is_blink_planner variable when creating `StreamTableEnvironment`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
