lirui-apache commented on a change in pull request #11201: [FLINK-16179][hive]
Use configuration from TableFactory in hive connector
URL: https://github.com/apache/flink/pull/11201#discussion_r383714212
##########
File path:
flink-connectors/flink-connector-hive/src/main/java/org/apache/flink/connectors/hive/HiveTableSource.java
##########
@@ -79,7 +78,8 @@
private static final Logger LOG =
LoggerFactory.getLogger(HiveTableSource.class);
- private final JobConf jobConf;
+ private final JobConf hiveConf;
Review comment:
Let's not change the name to `hiveConf` since it's not an instance of
`HiveConf`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
