klion26 commented on a change in pull request #11202:
[FLINK-16247][checkpoints] Various cleanups in checkpointing code
URL: https://github.com/apache/flink/pull/11202#discussion_r383744546
##########
File path:
flink-libraries/flink-state-processing-api/src/main/java/org/apache/flink/state/api/Savepoint.java
##########
@@ -52,7 +53,7 @@ private Savepoint() {}
* @param stateBackend The state backend of the savepoint.
*/
public static ExistingSavepoint load(ExecutionEnvironment env, String
path, StateBackend stateBackend) throws IOException {
- org.apache.flink.runtime.checkpoint.savepoint.Savepoint
savepoint = SavepointLoader.loadSavepoint(path);
+ CheckpointMetadata savepoint =
SavepointLoader.loadSavepoint(path);
Review comment:
Maybe we need to update the variable name `savepoint` here.
And do we need to update the function name of
`SavepointLoader#loadSavepoint`.
After the refractory, seems a little strange that we pass a loaded savepoint
to a `CheckpointMetadata`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
