azagrebin commented on a change in pull request #10890:
[FLINK-15198][Deployment / Mesos] remove mesos.resourcemanager.tasks.mem
URL: https://github.com/apache/flink/pull/10890#discussion_r383779914
##########
File path:
flink-mesos/src/main/java/org/apache/flink/mesos/runtime/clusterframework/MesosTaskManagerParameters.java
##########
@@ -429,26 +418,15 @@ private static double getCpuCores(final Configuration
configuration) {
}
private static MemorySize getTotalProcessMemory(final Configuration
configuration) {
- MemorySize legacyTotalProcessMemory =
MemorySize.parse(configuration.getInteger(MESOS_RM_TASKS_MEMORY_MB) + "m");
MemorySize unifiedTotalProcessMemory =
configuration.get(TaskManagerOptions.TOTAL_PROCESS_MEMORY);
- if (configuration.contains(MESOS_RM_TASKS_MEMORY_MB) &&
-
configuration.contains(TaskManagerOptions.TOTAL_PROCESS_MEMORY) &&
-
!legacyTotalProcessMemory.equals(unifiedTotalProcessMemory)) {
+ if
(!configuration.contains(TaskManagerOptions.TOTAL_PROCESS_MEMORY)) {
Review comment:
Indeed, we do not need this method `getTotalProcessMemory` anymore.
`TaskExecutorProcessUtils` will parse the options in
`createContaineredTaskManagerParameters`.
Subsequently, we do not need `.withTotalProcessMemory(totalProcessMemory)`
in `createContaineredTaskManagerParameters`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
