JingsongLi commented on a change in pull request #11204: [FLINK-16264][table] 
Fix ConnectTableDescriptor loose time attribute bug
URL: https://github.com/apache/flink/pull/11204#discussion_r383785092
 
 

 ##########
 File path: 
flink-table/flink-sql-client/src/test/java/org/apache/flink/table/client/gateway/utils/TestTableSourceFactoryBase.java
 ##########
 @@ -100,7 +100,7 @@ public TestTableSourceFactoryBase(String type, String 
testProperty) {
        public StreamTableSource<Row> 
createTableSource(TableSourceFactory.Context context) {
                TableSchema schema = context.getTable().getSchema();
                final DescriptorProperties params = new 
DescriptorProperties(true);
-               params.putProperties(context.getTable().getProperties());
+               params.putProperties(context.getTable().toProperties());
 
 Review comment:
   The class was `createTableSource(properties)`, we should revert to that 
properties.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to