JingsongLi commented on a change in pull request #11045:
[FLINK-15579][table-planner-blink] Support UpsertStreamTableSink on Blink batch
mode.
URL: https://github.com/apache/flink/pull/11045#discussion_r383801351
##########
File path:
flink-table/flink-table-planner-blink/src/main/scala/org/apache/flink/table/planner/plan/nodes/physical/batch/BatchExecSink.scala
##########
@@ -81,13 +81,39 @@ class BatchExecSink[T](
override protected def translateToPlanInternal(
planner: BatchPlanner): Transformation[Any] = {
val resultTransformation = sink match {
- case _: RetractStreamTableSink[T] | _: UpsertStreamTableSink[T] =>
- throw new TableException("RetractStreamTableSink and
UpsertStreamTableSink is not" +
- " supported in Batch environment.")
-
case streamTableSink: StreamTableSink[T] =>
- // we can insert the bounded DataStream into a StreamTableSink
- val transformation = translateToTransformation(withChangeFlag = false,
planner)
+ val transformation = streamTableSink match {
Review comment:
Can you add some it case to `TableSinkITCase`? Tests are in planner better
than connectors.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
