hequn8128 commented on a change in pull request #11130: 
[FLINK-15972][python][table-planner][table-planner-blink] Add Python building 
blocks to make sure the basic functionality of Python TableFunction could work
URL: https://github.com/apache/flink/pull/11130#discussion_r384238861
 
 

 ##########
 File path: flink-python/pyflink/fn_execution/coders.py
 ##########
 @@ -38,6 +39,38 @@
            'TimestampCoder', 'ArrayCoder', 'MapCoder', 'DecimalCoder']
 
 
+class TableFunctionRowCoder(FastCoder):
+    """
+    Coder for Table Function Row.
+    """
+    def __init__(self, row_coder):
 
 Review comment:
   How about rename row_coder to flatten_row_coder? It is more clear to 
distinguish flatten_row_coder from row_coder

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to