Github user mjsax commented on a diff in the pull request:
https://github.com/apache/flink/pull/1398#discussion_r45970389
--- Diff:
flink-contrib/flink-storm/src/main/java/org/apache/flink/storm/wrappers/FlinkTopologyContext.java
---
@@ -27,13 +27,12 @@
import backtype.storm.state.ISubscribedState;
import backtype.storm.task.TopologyContext;
import backtype.storm.tuple.Fields;
+import clojure.lang.Atom;
--- End diff --
Good we are on the same page. And I don't want to bully you! I just
mentioned the classes that do not contain any actual code change -- actually,
according to the coding guidelines -- there should be no import-order changes
even in the classes with code changes -- I did not comment on them -- just on
the classes with pure reformatting. I like consistency so please apply the
changes to all classes. But I did import-reorderings or making code formatting
consistent (if it was inconsistent) and was always told "don't do this". So if
it is a general rule, I just point it out here, too. I did not come up with the
rule. And I never force my own code style -- a always adapt to the given style.
:) It's is really about time to get a proper maven formatting tool running to
get rid of all this stupid discussions. (And a said already: "It is not against
you or the change itself" -- but the process seems to be inconsistent -- people
follow the rules more or less strictly)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
