rmetzger commented on a change in pull request #11222: [FLINK-15834] Set up
nightly builds in Azure & various CI improvements
URL: https://github.com/apache/flink/pull/11222#discussion_r384483762
##########
File path: tools/azure-pipelines/jobs-template.yml
##########
@@ -132,20 +134,26 @@ jobs:
restoreKeys: $(CACHE_FALLBACK_KEY)
path: $(MAVEN_CACHE_FOLDER)
displayName: Cache Maven local repo
+ continueOnError: true
# download artifacts
- task: DownloadPipelineArtifact@2
inputs:
path: $(CACHE_FLINK_DIR)
artifact: FlinkCompileCacheDir-${{parameters.stage_name}}
+ - script: |
+ echo "##vso[task.setvariable variable=JAVA_HOME]$(JAVA_HOME_11_X64)"
Review comment:
Correct, this is a bit ugly. I basically decide whether we are using jdk11
or not based on the container name (that is not used in this context).
I can address this as follows: I build a generic docker image (that does not
distinguish between jdk8 / jdk11 because it contains both), and I switch the
jdk version for docker and azure machines the same way.
Are you okay if I address this in a follow up? (I can only test this during
the night, because I would overwhelm the available machines)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
