zentol commented on a change in pull request #10995: [FLINK-15847][ml] Include
flink-ml-api and flink-ml-lib in opt
URL: https://github.com/apache/flink/pull/10995#discussion_r384484556
##########
File path: flink-ml-parent/flink-ml-lib/pom.xml
##########
@@ -57,4 +60,30 @@ under the License.
<version>1.1.2</version>
</dependency>
</dependencies>
+
+ <build>
+ <plugins>
+ <!-- Build flink-ml-lib jar -->
+ <plugin>
+ <groupId>org.apache.maven.plugins</groupId>
+ <artifactId>maven-shade-plugin</artifactId>
Review comment:
I would move this (and the corresponding NOTICE) into the `uber` module.
The basic idea is that the `uber` module is responsible for all things
related to the distribution. The individual modules usually shouldn't have to
shade dependencies; users should set flink-ml dependencies to provided anyways
so we don't have to concerned about them accidently bundling this dependency.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
