igalshilman commented on a change in pull request #36: [FLINK-16123] Add auto-routable Protobuf Kafka ingress URL: https://github.com/apache/flink-statefun/pull/36#discussion_r384471167
########## File path: statefun-flink/statefun-flink-core/src/main/java/org/apache/flink/statefun/flink/core/protorouter/AutoRoutableProtobufRouter.java ########## @@ -0,0 +1,67 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.flink.statefun.flink.core.protorouter; + +import com.google.protobuf.Any; +import com.google.protobuf.ByteString; +import com.google.protobuf.Message; +import org.apache.flink.statefun.flink.io.generated.AutoRoutable; +import org.apache.flink.statefun.flink.io.generated.TargetFunctionType; +import org.apache.flink.statefun.flink.io.kafka.ProtobufKafkaIngressTypes; +import org.apache.flink.statefun.sdk.Address; +import org.apache.flink.statefun.sdk.FunctionType; +import org.apache.flink.statefun.sdk.io.Router; + +/** + * A {@link Router} that recognizes messages of type {@link AutoRoutable}. + * + * <p>For each incoming {@code AutoRoutable}, this router forwards the wrapped payload to the + * configured target addresses as a Protobuf {@link Any} message. This should only be attached to + * ingress types of {@link ProtobufKafkaIngressTypes#ROUTABLE_PROTOBUF_KAFKA_INGRESS_TYPE}. + */ +public final class AutoRoutableProtobufRouter implements Router<Message> { + + @Override + public void route(Message message, Downstream<Message> downstream) { + final AutoRoutable routable = asAutoRoutable(message); + for (TargetFunctionType targetFunction : routable.getConfig().getTargetFunctionTypesList()) { + downstream.forward( Review comment: can you use the forward overloaded method that accepts a functionType and Id? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
