[
https://issues.apache.org/jira/browse/FLINK-3081?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15028947#comment-15028947
]
ASF GitHub Bot commented on FLINK-3081:
---------------------------------------
Github user StephanEwen commented on a diff in the pull request:
https://github.com/apache/flink/pull/1410#discussion_r45985979
--- Diff:
flink-streaming-connectors/flink-connector-kafka/src/main/java/org/apache/flink/streaming/connectors/kafka/FlinkKafkaConsumer.java
---
@@ -415,13 +415,17 @@ public void run(SourceContext<T> sourceContext)
throws Exception {
long commitInterval =
Long.valueOf(props.getProperty("auto.commit.interval.ms", "60000"));
offsetCommitter = new
PeriodicOffsetCommitter(commitInterval, this);
offsetCommitter.start();
+ offsetCommitter.setDaemon(true);
--- End diff --
I think that has to be before `start()` (otherwise it fails)
> Kafka Periodic Offset Committer does not properly terminate on canceling
> ------------------------------------------------------------------------
>
> Key: FLINK-3081
> URL: https://issues.apache.org/jira/browse/FLINK-3081
> Project: Flink
> Issue Type: Bug
> Components: Kafka Connector
> Affects Versions: 0.10.1
> Reporter: Stephan Ewen
> Assignee: Robert Metzger
> Priority: Blocker
> Fix For: 1.0.0, 0.10.2
>
>
> The committer is only stopped at the end of the run method. Any termination
> of the run method via an exception keeps the periodic committer thread
> running.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
