JingsongLi opened a new pull request #11229: [FLINK-16265][table][csv] CsvTableSinkFactoryBase should compare LogicalTypes instead of TableSchema URL: https://github.com/apache/flink/pull/11229 ## What is the purpose of the change ``` - name: TableSourceSink type: source-sink-table schema: - name: IntegerField type: INT - name: StringField type: VARCHAR - name: TimestampField type: TIMESTAMP connector: type: filesystem format: type: csv fields: - name: IntegerField type: INT - name: StringField type: VARCHAR - name: TimestampField type: TIMESTAMP line-delimiter: "\n" comment-prefix: "#" ``` Table like this will fail in SQL-CLI. The root cause is we will convert the properties into CatalogTableImpl and then convert into properties again. The schema type properties will use new type systems then which is not equal to the legacy types due to conversion classes. ## Brief change log We should avoid compare TableSchema in `CsvTableSinkFactoryBase.createTableSink`. ## Verifying this change `LocalExecutorITCase` ## Does this pull request potentially affect one of the following parts: - Dependencies (does it add or upgrade a dependency): (yes / **no**) - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (yes / **no**) - The serializers: (yes / **no** / don't know) - The runtime per-record code paths (performance sensitive): (yes / **no** / don't know) - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn/Mesos, ZooKeeper: (yes / **no** / don't know) - The S3 file system connector: (yes / **no** / don't know) ## Documentation - Does this pull request introduce a new feature? (yes / **no**)
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
