[
https://issues.apache.org/jira/browse/FLINK-16300?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Zhu Zhu updated FLINK-16300:
----------------------------
Description:
Mockito is used in SchedulerTestUtils to mock ExecutionVertex and Execution for
testing. It fails to mock every getter so that other tests use it may encounter
NPE issues, e.g. ExecutionVertex#getID().
Mockito is also discouraged to be used in Flink tests. So I'd propose to rework
the utils with testing classes.
was:
Mockito is used in SchedulerTestUtils to mock ExecutionVertex and Execution for
testing. It fails to mock every getter so that other tests use it may encounter
NPE issues, e.g. ExecutionVertex#getID().
Mockito is also discouraged to be used in Flink tests. So I'd propose to
reworks the utils with testing classes.
> Rework SchedulerTestUtils with testing classes to replace mockito usages
> ------------------------------------------------------------------------
>
> Key: FLINK-16300
> URL: https://issues.apache.org/jira/browse/FLINK-16300
> Project: Flink
> Issue Type: Sub-task
> Components: Runtime / Coordination, Tests
> Affects Versions: 1.11.0
> Reporter: Zhu Zhu
> Assignee: Zhu Zhu
> Priority: Major
> Fix For: 1.11.0
>
>
> Mockito is used in SchedulerTestUtils to mock ExecutionVertex and Execution
> for testing. It fails to mock every getter so that other tests use it may
> encounter NPE issues, e.g. ExecutionVertex#getID().
> Mockito is also discouraged to be used in Flink tests. So I'd propose to
> rework the utils with testing classes.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
