zhuzhurk commented on issue #11148: [FLINK-16180][runtime] Replace the nullable 
vertexExecution in ScheduledUnit with a non-null executionVertexId
URL: https://github.com/apache/flink/pull/11148#issuecomment-591836460
 
 
   @GJL FLINK-16300 is opened to rework `SchedulerTestUtils` to create a test 
`Execution` and the PR is #11230.
   It's not very urgent to get rid of mockito. However, in my previous 
experience, we can leave it as is if we do not touch it, but should not 
continuing make changes to those mockito usages.
   I'm not pretty sure whether creating testing subclasses is not clean. But I 
can see in Flink we have already doing it like this for tests, e.g. 
TestingSlotPoolImpl.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to