twalthr commented on a change in pull request #11081: [FLINK-16033][table-api]
Introduced Java Table API Expression DSL
URL: https://github.com/apache/flink/pull/11081#discussion_r385006297
##########
File path:
flink-table/flink-table-api-scala/src/main/scala/org/apache/flink/table/api/expressionDsl.scala
##########
@@ -1471,9 +715,22 @@ trait ImplicitExpressionConversions {
*
* Note: this user-defined function does not skip empty strings. However,
it does skip any NULL
* values after the separator argument.
+ * @deprecated use [[ImplicitExpressionConversions.concatWs()]]
**/
+ @deprecated
def concat_ws(separator: Expression, string: Expression, strings:
Expression*): Expression = {
- unresolvedCall(CONCAT_WS, separator +: string +: strings: _*)
+ concatWs(separator, string, strings: _*)
+ }
+
+ /**
+ * Returns the string that results from concatenating the arguments and
separator.
+ * Returns NULL If the separator is NULL.
+ *
+ * Note: this user-defined function does not skip empty strings. However, it
does skip any NULL
Review comment:
nit: `Note: This function does not`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
