rkhachatryan commented on a change in pull request #11219:
[FLINK-16257][network] Remove useless ResultPartitionID from AddCredit message
URL: https://github.com/apache/flink/pull/11219#discussion_r385101114
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/io/network/netty/NettyMessage.java
##########
@@ -666,10 +663,7 @@ ByteBuf write(ByteBufAllocator allocator) throws
IOException {
ByteBuf result = null;
try {
- result = allocateBuffer(allocator, ID, 16 + 16
+ 4 + 16);
-
- partitionId.getPartitionId().writeTo(result);
- partitionId.getProducerId().writeTo(result);
+ result = allocateBuffer(allocator, ID, 4 + 16);
Review comment:
nit: replace numbers with constants `Integer.BYTES` and `Long.BYTES`?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
