rmetzger commented on a change in pull request #11241: [FLINK-16292][build system] Add missing end to end tests URL: https://github.com/apache/flink/pull/11241#discussion_r385103236
########## File path: flink-end-to-end-tests/run-nightly-tests.sh ########## @@ -161,69 +161,7 @@ run_test "Walkthrough Table Scala nightly end-to-end test" "$END_TO_END_DIR/test run_test "Walkthrough DataStream Java nightly end-to-end test" "$END_TO_END_DIR/test-scripts/test_datastream_walkthroughs.sh java" run_test "Walkthrough DataStream Scala nightly end-to-end test" "$END_TO_END_DIR/test-scripts/test_datastream_walkthroughs.sh scala" -run_test "Test PubSub connector with Docker based Google PubSub Emulator" "$END_TO_END_DIR/test-scripts/test_streaming_gcp_pubsub.sh" Review comment: I was considering setting up another file like this for the ci runs (but then it would be even harder to keep things in sync) Given how aggressive the end to end test scripts modify things on the file system, I doubt that many people use these scripts. That's why I decided for this approach. How about keeping this file, and I comment out, instead of deleting? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
