rkhachatryan commented on a change in pull request #11061: [FLINK-15782] [connectors/jdbc] JDBC sink DataStream API URL: https://github.com/apache/flink/pull/11061#discussion_r385155172
########## File path: flink-connectors/flink-jdbc/src/main/java/org/apache/flink/api/java/io/jdbc/JdbcConnectionOptions.java ########## @@ -0,0 +1,94 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.flink.api.java.io.jdbc; + +import org.apache.flink.annotation.PublicEvolving; +import org.apache.flink.util.Preconditions; + +import java.io.Serializable; + +/** + * JDBC connection options. + */ +@PublicEvolving +public class JdbcConnectionOptions implements Serializable { + + private static final long serialVersionUID = 1L; + + protected final String url; + protected final String driverName; + protected final String username; + protected final String password; + + public JdbcConnectionOptions(String url, String driverName, String username, String password) { + this.url = Preconditions.checkNotNull(url, "jdbc url is empty"); + this.driverName = Preconditions.checkNotNull(driverName, "driver name is empty"); + this.username = username; + this.password = password; + } + + public String getDbURL() { + return url; + } + + public String getDriverName() { + return driverName; + } + + public String getUsername() { + return username; + } + + public String getPassword() { + return password; + } + Review comment: This name clashes with `JDBCOptions#builder` which is part of current public API. I didn't want to have similar methods named differently so I decided just to create builder with `new`. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
