leonardBang commented on a change in pull request #11223: [FLINK-16281][Table 
SQL / Ecosystem] parameter 'maxRetryTimes' can not work in JDBCUpsertTableSink.
URL: https://github.com/apache/flink/pull/11223#discussion_r385159325
 
 

 ##########
 File path: 
flink-connectors/flink-jdbc/src/main/java/org/apache/flink/api/java/io/jdbc/writer/AppendOnlyWriter.java
 ##########
 @@ -38,6 +40,7 @@
        private final String insertSQL;
        private final int[] fieldTypes;
 
+       private transient List<Row> cachedRows;
        private transient PreparedStatement statement;
 
 Review comment:
   Could you give more tips? add some unit  tests for  checking/validating what.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to