[ 
https://issues.apache.org/jira/browse/FLINK-16215?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17042036#comment-17042036
 ] 

Till Rohrmann edited comment on FLINK-16215 at 2/27/20 2:57 PM:
----------------------------------------------------------------

I think at the moment I would not recommend to do it because when recovering 
the previous containers we assume that a {{TaskExecutor}} has already been 
started in the container. I think this is not necessarily true and it could 
simply mean that we have obtained a container which we don't use. If this gets 
fixed and if we can guarantee that in every container there is a 
{{TaskExecutor}} running, then I believe that we could add slots belonging to 
these "not yet" registered {{TaskExecutors}} as pending slots.


was (Author: till.rohrmann):
I think at the moment I would not recommend to do it because when recovering 
the previous containers we assume that a {{TaskExecutor}} has already been 
started in the container. I think this is not necessarily true and it could 
simply mean that we have obtained a container which we don't use. If this gets 
fixed and if we can guarantee that in every container there is a 
{{TaskExecutor}} running, then I believe that we could slots belonging to these 
"not yet" registered {{TaskExecutors}} as pending slots.

> Start redundant TaskExecutor when JM failed
> -------------------------------------------
>
>                 Key: FLINK-16215
>                 URL: https://issues.apache.org/jira/browse/FLINK-16215
>             Project: Flink
>          Issue Type: Bug
>          Components: Runtime / Coordination
>    Affects Versions: 1.10.0
>            Reporter: YufeiLiu
>            Priority: Major
>
> TaskExecutor will reconnect to the new ResourceManager leader when JM failed, 
> and JobMaster will restart and reschedule job. If job slot request arrive 
> earlier than TM registration, RM will start new workers rather than reuse the 
> existing TMs.
> It‘s hard to reproduce becasue TM registration usually come first, and 
> timeout check will stop redundant TMs. 
> But I think it would be better if we make the {{recoverWokerNode}} to 
> interface, and put recovered slots in {{pendingSlots}} wait for TM 
> reconnection.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to