hwanju commented on issue #11196: [FLINK-16246][connector kinesis] Exclude AWS 
SDK MBean registry from Kinesis build
URL: https://github.com/apache/flink/pull/11196#issuecomment-592035356
 
 
   @StephanEwen The solution seems clean to me.
   Still a connector may not clean something maintained in a library it depends 
on (e.g. KPL) if cleanup API is not provided, like `FileAgeManager`, but anyway 
it needs your proposed API to register cleanup hook and once it's there, we can 
suggest how some library like KPL can be more Flink-friendly (like don't assume 
sharing lifecycle with JVM - but yeah "library" actually shouldn't have assumed 
it in the first place...).
   
   Re: multiple jobs and plugin dependency, I had the same understanding as 
Stephan, specifically about the issues I am aware of, but I was not sure about 
MBean issue, but based on what Stephan said, it seems like MBean is per 
classloader. So, that'd be right that cleanup hook is a solution as long as 
user leak happens per user classloader not leaking into global JVM structure. I 
see several user leak is such a case per classloader (but not necessarily all).

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to