dawidwys commented on a change in pull request #11081: [FLINK-16033][table-api]
Introduced Java Table API Expression DSL
URL: https://github.com/apache/flink/pull/11081#discussion_r385227403
##########
File path:
flink-table/flink-table-api-java/src/main/java/org/apache/flink/table/expressions/LookupCallExpression.java
##########
@@ -43,7 +42,7 @@
LookupCallExpression(String unresolvedFunction, List<Expression> args) {
this.unresolvedName =
Preconditions.checkNotNull(unresolvedFunction);
- this.args = Collections.unmodifiableList(new
ArrayList<>(Preconditions.checkNotNull(args)));
+ this.args =
Collections.unmodifiableList(Preconditions.checkNotNull(args));
Review comment:
Honestly I don't know if it makes sense to be so defensive here.
Usually the arguments are constructed either with `Arrays.asList` or via
stream API which produce unmodifiable lists anyway. I was tempted to remove
even the `unmodifiableList`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
