[
https://issues.apache.org/jira/browse/FLINK-2624?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15029802#comment-15029802
]
ASF GitHub Bot commented on FLINK-2624:
---------------------------------------
Github user mxm commented on a diff in the pull request:
https://github.com/apache/flink/pull/1243#discussion_r46040790
--- Diff:
flink-staging/flink-streaming/flink-streaming-connectors/flink-connector-rabbitmq/src/main/java/org/apache/flink/streaming/connectors/rabbitmq/RMQSource.java
---
@@ -89,12 +99,16 @@ public void run(SourceContext<OUT> ctx) throws
Exception {
while (running) {
delivery = consumer.nextDelivery();
- OUT result = schema.deserialize(delivery.getBody());
- if (schema.isEndOfStream(result)) {
- break;
+ synchronized (ctx.getCheckpointLock()) {
+ OUT result =
schema.deserialize(delivery.getBody());
+ addId(ctx,
delivery.getEnvelope().getDeliveryTag());
--- End diff --
This looks like it will grow the id array infinitely when the checkpointing
is disabled.
> RabbitMQ source / sink should participate in checkpointing
> ----------------------------------------------------------
>
> Key: FLINK-2624
> URL: https://issues.apache.org/jira/browse/FLINK-2624
> Project: Flink
> Issue Type: Bug
> Components: Streaming Connectors
> Affects Versions: 0.10.0
> Reporter: Stephan Ewen
> Assignee: Hilmi Yildirim
>
> The RabbitMQ connector does not offer any fault tolerance guarantees right
> now, because it does not participate in the checkpointing.
> We should integrate it in a similar was as the {{FlinkKafkaConsumer}} is
> integrated.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
