zentol edited a comment on issue #11173: [FLINK-13417][build] Bundle Zookeeper 3.5 in opt URL: https://github.com/apache/flink/pull/11173#issuecomment-591402360 One example for `curator-test` being used outside of `flink-runtime` is `flink-tests`, which runs some Zookeeper IT cases. For these the curator-test version has to correspond to the version in flink-runtime. So this isn't just a problem in the build system but also how we write tests. AFAIK some other modules also use curator-test but the flink-runtime ZK may not necessarily be involved here. Ultimately I don't know what most of these modules do with Zookeeper, but I understood the JIRA to add ZK 3.5 support for _all modules_, not just flink-runtime. I had an offline chat with Till about this PR. He raised a good argument in that the "global ZK version" approach is flawed as any module bundling ZK (apart from flink-runtime) is hard-wired at compile-time to that version anyway, with no way for users to switch versions aside from recompiling Flink. Additionally, it shouldn't be required to actually test against both ZK 3.4 and 3.5 . So long as we use 3.4 as the default curator should ensure that we can talk to both versions. Simply put we propose to the drop the ZK 3.5 profile, only run unit/it tests against ZK 3.4, and possible adjust an E2E test to run against 3.5, with the added benefit of actually testing how users would switch between versions.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
