gaoyunhaii commented on a change in pull request #7368: [FLINK-10742][network] Let Netty use Flink's buffers directly in credit-based mode URL: https://github.com/apache/flink/pull/7368#discussion_r385451186
########## File path: flink-runtime/src/main/java/org/apache/flink/runtime/io/network/netty/NettyMessageDecoder.java ########## @@ -0,0 +1,80 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.flink.runtime.io.network.netty; + +import org.apache.flink.shaded.netty4.io.netty.buffer.ByteBuf; +import org.apache.flink.shaded.netty4.io.netty.channel.ChannelHandlerContext; + +/** + * Base class of decoders for specified netty messages. + */ +abstract class NettyMessageDecoder implements AutoCloseable { + + /** ID of the message under decoding. */ + protected int msgId; + + /** Length of the message under decoding. */ + protected int messageLength; + + /** + * The result of decoding one netty buffer. + */ + static class DecodingResult { + final static DecodingResult NOT_FINISHED = new DecodingResult(false, null); + + static DecodingResult fullMessage(NettyMessage message) { + return new DecodingResult(true, message); + } + + final boolean finished; + + final NettyMessage message; + + private DecodingResult(boolean finished, NettyMessage message) { + this.finished = finished; + this.message = message; + } + } + + /** + * Notifies that the underlying channel become active. + * + * @param ctx The context for the callback. + */ + abstract void onChannelActive(ChannelHandlerContext ctx); + + /** + * Notifies that a new message is to be decoded. + * + * @param msgId The type of the message to be decoded. + * @param messageLength The length of the message to be decoded. + */ + void onNewMessageReceived(int msgId, int messageLength) { + this.msgId = msgId; + this.messageLength = messageLength; + } + + /** + * Notifies that more data is received for the decoding message. Review comment: Fixed. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
