zhijiangW commented on a change in pull request #7368: [FLINK-10742][network]
Let Netty use Flink's buffers directly in credit-based mode
URL: https://github.com/apache/flink/pull/7368#discussion_r385500959
##########
File path:
flink-runtime/src/test/java/org/apache/flink/runtime/io/network/netty/CreditBasedPartitionRequestClientHandlerTest.java
##########
@@ -430,23 +431,35 @@ private static void releaseResource(SingleInputGate
inputGate, NetworkBufferPool
/**
* Returns a deserialized buffer message as it would be received during
runtime.
*/
- private static BufferResponse createBufferResponse(
+ private BufferResponse createBufferResponse(
Buffer buffer,
int sequenceNumber,
- InputChannelID receivingChannelId,
- int backlog) throws IOException {
+ RemoteInputChannel receivingChannel,
Review comment:
It is better to still use previous `receivingChannelId` instead, because we
actually only need it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
