[
https://issues.apache.org/jira/browse/FLINK-16274?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17047259#comment-17047259
]
Tzu-Li (Gordon) Tai commented on FLINK-16274:
---------------------------------------------
[~igal] thanks for the comment.
{quote}
a) Having users (statefun core devs) supplying the flink-conf.yaml as part of
the e2e test makes the e2e test
more likely to catch property renaming in Flink.
{quote}
I'm not sure I'm following your thoughts on this.
If a config key happens to be renamed in Flink / Statefun, the e2e should still
catch them all the same, because in the end _some_ flink-conf.yaml is being
used.
{quote}
b) It requires pulling in a dependency on flink-statefun-core into the test
driving code, that is otherwise independent of the runtime which is a very nice
property for an end-to-end black box test.
{quote}
The only reason we have that extra dependency on {{statefun-flink-core}} right
now is only due to this:
https://github.com/apache/flink-statefun/pull/35/files#diff-663c1410bf2a21982e28d4512b1de018R161
I feel like this can be resolved by perhaps moving the configuration-related
classes to a common module, instead of residing in core.
> Add typed builder methods for setting dynamic configuration on
> StatefulFunctionsAppContainers
> ---------------------------------------------------------------------------------------------
>
> Key: FLINK-16274
> URL: https://issues.apache.org/jira/browse/FLINK-16274
> Project: Flink
> Issue Type: New Feature
> Components: Stateful Functions, Test Infrastructure
> Affects Versions: statefun-1.1
> Reporter: Tzu-Li (Gordon) Tai
> Assignee: Tzu-Li (Gordon) Tai
> Priority: Major
> Labels: pull-request-available
> Time Spent: 10m
> Remaining Estimate: 0h
>
> Excerpt from:
> https://github.com/apache/flink-statefun/pull/32#discussion_r383644382
> Currently, you'd need to provide a complete {{Configuration}} as dynamic
> properties when constructing a {{StatefulFunctionsAppContainers}}.
> It'll be nicer if this is built like this:
> {code}
> public StatefulFunctionsAppContainers verificationApp =
> new StatefulFunctionsAppContainers("sanity-verification", 2)
> .withModuleGlobalConfiguration("kafka-broker",
> kafka.getBootstrapServers())
> .withConfiguration(ConfigOption option, configValue)
> {code}
> And by default the {{StatefulFunctionsAppContainers}} just only has the
> configs in the base template {{flink-conf.yaml}}.
> This would require lazy construction of the containers on {{beforeTest}}.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
