hequn8128 commented on a change in pull request #11220:
[FLINK-16249][python][ml] Add interfaces for Params, ParamInfo and WithParams
URL: https://github.com/apache/flink/pull/11220#discussion_r385546143
##########
File path: flink-python/setup.py
##########
@@ -224,7 +224,7 @@ def remove_if_exists(file_path):
author_email='[email protected]',
python_requires='>=3.5',
install_requires=['py4j==0.10.8.1', 'python-dateutil==2.8.0',
'apache-beam==2.19.0',
- 'cloudpickle==1.2.2', 'avro-python3>=1.8.1,<=1.9.1'],
+ 'cloudpickle==1.2.2', 'avro-python3>=1.8.1,<=1.9.1',
'jsonpickle==1.2'],
Review comment:
Since we only introduce jsonpickle now and the dependency is rather small,
it does not hurt non-ML users while brings convenience for ML users. I find
more advantages here.
If we add NumPy support for ML, we can add all these dependencies into the
optional at that time.
What do you think?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
