[
https://issues.apache.org/jira/browse/FLINK-3088?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15029914#comment-15029914
]
ASF GitHub Bot commented on FLINK-3088:
---------------------------------------
GitHub user tillrohrmann opened a pull request:
https://github.com/apache/flink/pull/1415
[FLINK-3088] [serialization] Fix copy method of TypeSerializers which use
Kryo
Some TypeSerializer, WritableSerializer, ValueSerializer, and
AvroSerializer, and
comparators, WritableComparator and ValueComparator, use Kryo to copy
records.
In case where the Kryo serializer cannot copy the record, the copy method
fails.
This is however not necessary, because one can copy the element by
serializing
the record to a byte array and deserializing it from this array. This PR
adds
this behaviour to the respective classes.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/tillrohrmann/flink fixWritableSerializer
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/1415.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1415
----
commit e00efd5b00ed4d0af85313baeae3c676457253cb
Author: Till Rohrmann <[email protected]>
Date: 2015-11-27T14:14:15Z
[FLINK-3088] [serialization] Fix copy method of TypeSerializer which use
Kryo
Some TypeSerializer, WritableSerializer, ValueSerializer, and
AvroSerializer, and
comparators, WritableComparator and ValueComparator, use Kryo to copy
records.
In case where the Kryo serializer cannot copy the record, the copy method
fails.
This is however not necessary, because one can copy the element by
serializing
the record to a byte array and deserializing it from this array. This PR
adds
this behaviour to the respective classes.
----
> WritableSerializer cannot copy writable object
> ----------------------------------------------
>
> Key: FLINK-3088
> URL: https://issues.apache.org/jira/browse/FLINK-3088
> Project: Flink
> Issue Type: Bug
> Components: Core
> Affects Versions: 1.0.0, 0.10.1
> Reporter: Till Rohrmann
> Assignee: Till Rohrmann
>
> The {{WritableSerializer}}, {{ValueSerializer}}, {{AvroSerializer}},
> {{WritableComparator}} and {{ValueComparator}} use plain {{Kryo}} instances
> to copy the objects. In cases where {{Kryo}} fails to copy the object, e.g.
> missing no-arg constructor, the serializer and comparator instances fail even
> though the objects are serializable.
> As a fallback strategy I propose to copy the objects by serializing and
> deserializing them.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
