Github user rmetzger commented on a diff in the pull request:
https://github.com/apache/flink/pull/1415#discussion_r46053491
--- Diff:
flink-java/src/main/java/org/apache/flink/api/java/typeutils/runtime/ValueComparator.java
---
@@ -63,7 +66,22 @@ public int hash(T record) {
@Override
public void setReference(T toCompare) {
checkKryoInitialized();
- reference = this.kryo.copy(toCompare);
--- End diff --
Why are we are using Kryo here in the first place? Why not the
ValueSerializer?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
