GJL commented on a change in pull request #11148: [FLINK-16180][runtime]
Replace the nullable vertexExecution in ScheduledUnit with a non-null
executionVertexId
URL: https://github.com/apache/flink/pull/11148#discussion_r385657743
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/jobmanager/scheduler/ScheduledUnit.java
##########
@@ -18,23 +18,21 @@
package org.apache.flink.runtime.jobmanager.scheduler;
+import org.apache.flink.annotation.VisibleForTesting;
import org.apache.flink.runtime.executiongraph.Execution;
import org.apache.flink.runtime.instance.SlotSharingGroupId;
import org.apache.flink.runtime.jobgraph.JobVertexID;
+import org.apache.flink.runtime.scheduler.strategy.ExecutionVertexID;
import org.apache.flink.util.Preconditions;
import javax.annotation.Nullable;
/**
- * ScheduledUnit contains the information necessary to allocate a slot for the
given
- * {@link JobVertexID}.
+ * ScheduledUnit contains the information necessary to allocate a slot for the
given task.
*/
public class ScheduledUnit {
- @Nullable
- private final Execution vertexExecution;
-
- private final JobVertexID jobVertexId;
+ private final ExecutionVertexID executionVertexID;
Review comment:
I would name this `executionVertexId` (compare with the member below:
`slotSharingGroupId`)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
