zentol commented on a change in pull request #11256:
[FLINK-16342][metrics][datadog] Remove mocking
URL: https://github.com/apache/flink/pull/11256#discussion_r385811793
##########
File path:
flink-metrics/flink-metrics-datadog/src/main/java/org/apache/flink/metrics/datadog/DatadogHttpClient.java
##########
@@ -48,6 +48,8 @@
private static final int TIMEOUT = 3;
private static final ObjectMapper MAPPER = new ObjectMapper();
+ static boolean skipApiKeyValidation = false;
Review comment:
I would go with that solution once factories are in place; as it stands we
would need 2 constructors; one with the arguments, one no-arg constructor for
reflection purposes (which would be detected as being unused), and I don't want
to have to watch out for someone removing the constructor because he thought
it's not used anyway, or migrate tests towards the new "convenient" constructor
at which point we lose test coverage of runtime paths.
I know it's super icky and Ideally we get rid of the reflection approach
soon.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
