azagrebin commented on a change in pull request #11240: [FLINK-16190][e2e] Migrate tests to FlinkResource URL: https://github.com/apache/flink/pull/11240#discussion_r385810896
########## File path: flink-end-to-end-tests/flink-end-to-end-tests-common/src/main/java/org/apache/flink/tests/util/flink/FlinkResourceSetup.java ########## @@ -0,0 +1,87 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.flink.tests.util.flink; + +import org.apache.flink.configuration.Configuration; +import org.apache.flink.util.Preconditions; + +import javax.annotation.Nullable; + +import java.util.ArrayList; +import java.util.Collection; +import java.util.Optional; + +/** + * Setup instructions for a {@link FlinkResource}. + */ +public class FlinkResourceSetup { + + @Nullable + private final Configuration config; + private final Collection<JarMove> jarMoveOperations; + + private FlinkResourceSetup(@Nullable Configuration config, Collection<JarMove> jarMoveOperations) { + this.config = config; + this.jarMoveOperations = Preconditions.checkNotNull(jarMoveOperations); + } + + public Optional<Configuration> getConfig() { + return Optional.ofNullable(config); + } + + public Collection<JarMove> getJarMoveOperations() { + return jarMoveOperations; + } + + public static FlinkResourceSetupBuilder builder() { + return new FlinkResourceSetupBuilder(); + } + + /** + * Builder for {@link FlinkResourceSetup}. + */ + public static class FlinkResourceSetupBuilder { + + private Configuration config; + private final Collection<String> jarsToCopyFromOptToLib = new ArrayList<>(); Review comment: unused leftover? although I would go with it for now instead of `jarMoveOperations` if there are no other use cases for it in foreseeable future ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
