xintongsong commented on a change in pull request #11248: [FLINK-16299] Release
containers recovered from previous attempt in w…
URL: https://github.com/apache/flink/pull/11248#discussion_r385995255
##########
File path:
flink-yarn/src/test/java/org/apache/flink/yarn/YarnResourceManagerTest.java
##########
@@ -178,7 +179,7 @@ public void teardown() throws Exception {
static class TestingYarnResourceManager extends YarnResourceManager {
AMRMClientAsync<AMRMClient.ContainerRequest>
mockResourceManagerClient;
- NMClientAsync mockNMClient;
+ TestingNMClientAsync testingNMClientAsync;
Review comment:
I think we can keep it declared as `NMClientAsync`. That ensures we use the
exact same set of public interfaces in the tests as in the production code.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
