xintongsong commented on a change in pull request #11248: [FLINK-16299] Release 
containers recovered from previous attempt in w…
URL: https://github.com/apache/flink/pull/11248#discussion_r386172732
 
 

 ##########
 File path: 
flink-yarn/src/test/java/org/apache/flink/yarn/YarnResourceManagerTest.java
 ##########
 @@ -446,8 +459,8 @@ public void testStopWorker() throws Exception {
 
                                unregisterAndReleaseFuture.get();
 
-                               
verify(mockNMClient).stopContainerAsync(any(ContainerId.class), 
any(NodeId.class));
                                
verify(mockResourceManagerClient).releaseAssignedContainer(any(ContainerId.class));
+                               
testingContainerStopFuture.get(TIMEOUT.getSize(), TIMEOUT.getUnit());
 
 Review comment:
   This should come before the previous line, because containers are first 
stopped, then released.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to