carp84 commented on a change in pull request #10768: [FLINK-15012][checkpoint]
Introduce shutdown to CheckpointStorageCoordinatorView to clean up checkpoint
directory.
URL: https://github.com/apache/flink/pull/10768#discussion_r386172856
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/state/CheckpointStorageCoordinatorView.java
##########
@@ -124,5 +117,5 @@ CheckpointStorageLocation initializeLocationForSavepoint(
*
* @throws IOException Thrown if the storage cannot be shut down well
due to an I/O exception.
*/
- void shutDown(JobStatus jobStatus) throws IOException;
+ void shutDown(JobStatus jobStatus, CheckpointProperties
checkpointProperties) throws IOException;
Review comment:
Please add javadoc for the newly added parameter.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
