nielsbasjes commented on a change in pull request #11245:
[FLINK-15794][Kubernetes] Generate the Kubernetes default image version
URL: https://github.com/apache/flink/pull/11245#discussion_r386328946
##########
File path:
flink-kubernetes/src/main/java/org/apache/flink/kubernetes/configuration/KubernetesConfigOptions.java
##########
@@ -121,8 +122,11 @@
public static final ConfigOption<String> CONTAINER_IMAGE =
key("kubernetes.container.image")
.stringType()
- .defaultValue("flink:latest")
- .withDescription("Image to use for Flink containers.");
+ .defaultValue("flink:" + Version.PROJECT_VERSION + "-scala_" +
Version.SCALA_VERSION)
Review comment:
I reported https://issues.apache.org/jira/browse/FLINK-16289 last week about
getting java.io.InvalidClassException:
org.apache.flink.table.codegen.GeneratedAggregationsFunction.
Root cause after several days of digging:
- I had scala 2.11 on my machine
- Downloaded Flink 1.10.0 for scala 2.11 to start my session on Kubernetes.
- Used Flink 1.10.0 for scala 2.11 for all dependencies in my project that I
built and ran.
- Then "Flink 1.10.0 for scala 2.11" on Kubernetes downloaded "flink:latest"
image which is really "Flink 1.10.0 for scala 2.12" which broke it all.
Also if for some reason I choose not to upgrade and a new release for Flink
is created (i.e. 1.11) then my application may also break.
So I think "Flink X for scala Y" must download the docker image for exactly
THAT combination of versions.
So I think having the scala version in there explicitly is a must have.
or ... We ditch the scala 2.11 variant completely and have only 1 scala
variant.
I'll have a look at the EnvironmentInformation you mentioned, perhaps that
is the better place to add the scala version.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
