zhuzhurk commented on issue #10858: [FLINK-15582] Change LegacySchedulerBatchSchedulingTest to DefaultSchedulerBatchSchedulingTest URL: https://github.com/apache/flink/pull/10858#issuecomment-593359435 @GJL I'd prefer to replace those legacy scheduling tests if they help for the new scheduler. Most of the test cases, however, does not test the scheduler but just depends on a scheduler to test some other behaviors, e.g. ExecutionGraphPartitionReleaseTest, ExecutionGraphSuspendTest. For these case I think we can replace with DefaultScheduler since DefaultScheduler is the default scheduler now. For the other tests which test the scheduling, including this one, if you feels it's better to keep the tests for legacy scheduler before we made the decision to remove it, we can postpone rewriting those tests to avoid some unnecessary duplicate work. For this PR, since I have such a PR already, I can revert it to the last version, namely having it testing both the legacy scheduler and new scheduler. WDYT?
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
