leonardBang commented on a change in pull request #11223: [FLINK-16281][Table SQL / Ecosystem] parameter 'maxRetryTimes' can not work in JDBCUpsertTableSink. URL: https://github.com/apache/flink/pull/11223#discussion_r386364383
########## File path: flink-connectors/flink-jdbc/src/test/java/org/apache/flink/api/java/io/jdbc/JDBCAppenOnlyWriterTest.java ########## @@ -0,0 +1,103 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.flink.api.java.io.jdbc; + +import org.apache.flink.api.common.ExecutionConfig; +import org.apache.flink.api.common.functions.RuntimeContext; +import org.apache.flink.api.java.io.jdbc.writer.AppendOnlyWriter; +import org.apache.flink.api.java.tuple.Tuple2; + +import org.junit.After; +import org.junit.Before; +import org.junit.Test; +import org.mockito.Mockito; + +import java.sql.BatchUpdateException; +import java.sql.Connection; +import java.sql.DriverManager; +import java.sql.Statement; + +import static org.apache.flink.api.java.io.jdbc.JDBCOutputFormatTest.toRow; +import static org.mockito.Mockito.doReturn; + +/** + * Test for the {@link AppendOnlyWriter}. + */ +public class JDBCAppenOnlyWriterTest extends JDBCTestBase { + private JDBCUpsertOutputFormat format; + private String[] fieldNames; + private String[] keyFields; + + @Before + public void setup() { + fieldNames = new String[]{"id", "title", "author", "price", "qty"}; + keyFields = null; + } + + @Test(expected = BatchUpdateException.class) + public void testMaxRetry() throws Exception { + format = JDBCUpsertOutputFormat.builder() + .setOptions(JDBCOptions.builder() + .setDBUrl(DB_URL) + .setTableName(OUTPUT_TABLE) + .build()) + .setFieldNames(fieldNames) + .setKeyFields(keyFields) + .build(); + RuntimeContext context = Mockito.mock(RuntimeContext.class); + ExecutionConfig config = Mockito.mock(ExecutionConfig.class); + doReturn(config).when(context).getExecutionConfig(); + doReturn(true).when(config).isObjectReuseEnabled(); + format.setRuntimeContext(context); + format.open(0, 1); + + // alter table schema to trigger retry logic after failure. + alterTable(); + for (TestEntry entry : TEST_DATA) { + format.writeRecord(Tuple2.of(true, toRow(entry))); + } + + // after retry default times, throws a BatchUpdateException. + format.flush(); + } + + private void alterTable() throws Exception { + Class.forName(DRIVER_CLASS); + try (Connection conn = DriverManager.getConnection(DB_URL); + Statement stat = conn.createStatement()) { + stat.execute("ALTER TABLE " + OUTPUT_TABLE + " DROP COLUMN " + fieldNames[1]); + stat.close(); Review comment: I see many this kind of style that call resource close() function in try(){} body in our code, I just want to align, should I keep this? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
