dawidwys commented on a change in pull request #11162:
[FLINK-11720][connectors] Bump ElasticSearch5 to 5.3.3
URL: https://github.com/apache/flink/pull/11162#discussion_r386381506
##########
File path:
flink-connectors/flink-connector-elasticsearch-base/src/main/java/org/apache/flink/streaming/connectors/elasticsearch/ElasticsearchSinkBase.java
##########
@@ -407,10 +410,19 @@ public void afterBulk(long executionId, BulkRequest
request, BulkResponse respon
LOG.error("Failed
Elasticsearch item request: {}", itemResponse.getFailureMessage(), failure);
restStatus =
itemResponse.getFailure().getStatus();
+ actionRequest =
request.requests().get(i);
if (restStatus == null)
{
-
failureHandler.onFailure(request.requests().get(i), failure, -1,
failureRequestIndexer);
+ if
(actionRequest instanceof ActionRequest) {
Review comment:
I am fine with how it is now. Did you consider just dropping the types of
failed requests we do not know, though?
Anyway none of those should happen as we only ever send ActionRequests.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
