[
https://issues.apache.org/jira/browse/FLINK-15621?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17049398#comment-17049398
]
Arujit Pradhan commented on FLINK-15621:
----------------------------------------
Hi [~azagrebin],
I have a doubt while implementing this story. Basically I was trying to find
the piece of code which enables `*ttlCompactionFilter*` to true by default. (I
can see the default value set to true in config), but I know we have to remove
that configuration altogether. I thought you would be setting that in rocks DB
or something, but could not find the implementation. Initially, I assumed that
its just deprecation code removal, but I am unable to find where are you
enabling compaction filter. And when I just removed the deprecated code
(thinking it was set by default somewhere) all tests in
*{color:#172b4d}RocksDBTtlStateTestBase
{color}* {color:#172b4d} are failing{color}. I know this is a trivial doubt.
But it would be really great if you can please help me here. I am new to
opensource and flink all together and it will help me in my first opensource
contribution.
{color:#50fa7b} {color}
> State TTL: Remove deprecated option and method to disable TTL compaction
> filter
> -------------------------------------------------------------------------------
>
> Key: FLINK-15621
> URL: https://issues.apache.org/jira/browse/FLINK-15621
> Project: Flink
> Issue Type: Task
> Components: Runtime / State Backends
> Reporter: Andrey Zagrebin
> Assignee: Arujit Pradhan
> Priority: Blocker
> Fix For: 1.11.0
>
>
> Follow-up for FLINK-15506.
> * Remove RocksDBOptions#TTL_COMPACT_FILTER_ENABLED
> * Remove
> RocksDBStateBackend#enableTtlCompactionFilter/isTtlCompactionFilterEnabled/disableTtlCompactionFilter,
> also in python API
> * Cleanup code from this flag and tests, also in python API
> * Check any related code in
> [frocksdb|https://github.com/dataArtisans/frocksdb] if any
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
